fix(igxGrid): Add handling for outlet in case actionstrip is added po…#16873
Merged
fix(igxGrid): Add handling for outlet in case actionstrip is added po…#16873
Conversation
MayaKirova
added
❌ status: awaiting-test
Contributor
Author
|
@copilot add a test for this scenario. |
Contributor
|
@MayaKirova I've opened a new pull request, #16874, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: MayaKirova <10397980+MayaKirova@users.noreply.github.com>
test(igxGrid): Add test for actionstrip outlet when added post-init
IMinchev64
approved these changes
Feb 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a grid overlay-outlet initialization gap when an IgxActionStrip is added dynamically after the grid has completed content init, addressing the Elements scenario where action-strip menus (as menu items) can close unexpectedly due to incorrect overlay outlet resolution.
Changes:
- Subscribes to
actionStripComponents.changesinIgxGridBaseDirectiveto (re)applymenuOverlaySettings.outletwhen the action strip is added/changed post-init. - Adds a new dynamic-action-strip test component in test utilities.
- Adds a unit test validating the action strip menu outlet is set when the strip is added after init.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
projects/igniteui-angular/grids/grid/src/grid-base.directive.ts |
Updates grid base lifecycle logic to set action strip menu overlay outlet on dynamic content changes. |
projects/igniteui-angular/test-utils/grid-samples.spec.ts |
Adds a test component that conditionally renders an action strip after initial render. |
projects/igniteui-angular/grids/grid/src/grid-add-row.spec.ts |
Adds a unit test asserting the outlet is applied for dynamically-added action strips. |
Contributor
|
@MayaKirova pr to 21.1.x please |
dkamburov
added
✅ status: verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…st init.
Closes #16850
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)